add minutes, seconds and remove isCA #686
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoe-tek
requested review from
fcanovai,
gbartolini,
itay-grudev,
leonardoce,
mnencia,
phisco and
sxd
as code owners
dosubot
bot
added
the
size:S
zied-jt
approved these changes
Oct 16, 2025
zied-jt
left a comment
zied-jt
left a comment
There was a problem hiding this comment.
LGFM
Source: https://cert-manager.io/docs/usage/certificate/ and https://cert-manager.io/docs/reference/api-docs/#cert-manager.io/v1.CertificateSpec
Value must be in units accepted by Go time.ParseDuration https://golang.org/pkg/time/#ParseDuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certificate resource removes isCA: false as it is the default and adds "0m0s" to the duration and renewBefore.
This change will allow a clean sync in argoCD.